Kondo linter tests for :metabase/validate-logging
#43104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
camsaul
commented
May 24, 2024
| (Thread/sleep interval-ms) | ||
| (Thread/sleep (long interval-ms)) |
There was a problem hiding this comment.
Fixed reflection warning introduced by #42316
|
@camsaul Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a way to run tests against Kondo linters.
Convert the test
commentexamples for our custom:metabase/validate-logginglinter to tests. This serves as an example of how to write tests for Kondo linters and a proof-of-concept.To make this work I moved
.clj-kondo/hooksto.clj-kondo/src/hooks; tests live in matching test namespace in.clj-kondo/test/hooks.I added an alias so you can easily run Kondo linter tests with
clj -X:dev:test:test/kondo.