Decouple channel and notification #43113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
piranha
reviewed
Jun 10, 2024
| [metabase.util.malli.schema :as ms] | ||
| [toucan2.core :as t2])) | ||
|
|
||
| (channel/register! :channel/slack) |
There was a problem hiding this comment.
did you mean :channel/email here?
piranha
reviewed
Jun 10, 2024
| (case (keyword condition-type) | ||
| :meets (trs "reached its goal") | ||
| :below (trs "gone below its goal") | ||
| :rows (trs "results"))) |
There was a problem hiding this comment.
I would prefer the whole subject generated in that one case, translation will be easier and of better quality.
|
We introduced channel in #43924. Notification can be done later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.