Remove Google Analytics driver #43352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsaul
added
the
backport
camsaul
commented
May 30, 2024
| junit-name: 'be-tests-googleanalytics-ee' | ||
| test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}" | ||
|
|
||
| be-google-related-drivers-classpath-test: |
There was a problem hiding this comment.
this job was to check that Google Analytics and Big Query dependencies didn't conflict with each other so we don't need it anymore
|
lbrdnk
approved these changes
May 30, 2024
| @@ -21,7 +21,6 @@ on: | |||
| - Athena | |||
| - BigQuery | |||
| - Druid | |||
| - Google Analytics | |||
| - Google Classpath Test | |||
There was a problem hiding this comment.
Google Classpath Test should not be removed?
| @@ -20,8 +20,7 @@ | |||
| "/enterprise/backend/src" | |||
| "/modules/drivers/bigquery-cloud-sdk/src" | |||
| "/modules/drivers/druid/src" | |||
| "/modules/drivers/google/src" | |||
| "/modules/drivers/googleanalytics/src" | |||
| "/modules/drivers/druid-jdbc/src" | |||
| @@ -33,70 +32,6 @@ | |||
| (throw (ex-info (format "Did not find %s.%s" (name table) (name column)) | |||
| {:table table :column column})))) | |||
|
|
|||
| (deftest ^:parallel field-matching-predicates-test | |||
There was a problem hiding this comment.
Why to remove whole test and not just ga: related parts?
|
@camsaul Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
camsaul
added a commit
that referenced
this pull request
Jun 5, 2024
* Remove Google Analytics driver * Remove more GA-related tests * Un-remove tests that aren't related to GA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I managed to remove all the special case stuff
Resolves #42792