Fix RowChart X-Axis ticks formatter #43783
Merged
+230
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove scaling from x-axis tick values like we did for y-axis tick values in ECharts charts
JesseSDevaney
added
backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e3f166b...a6caf7c.
|
|
alxnddr
approved these changes
Jun 6, 2024
JesseSDevaney
deleted the
row-charts-x-axis-formatting-applies-scaling-twice
branch
|
@JesseSDevaney Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-automation-metabase
pushed a commit
that referenced
this pull request
Jun 6, 2024
* fix RowChart XAxis ticks formatter - remove scaling from x-axis tick values like we did for y-axis tick values in ECharts charts * add loki variant
github-automation-metabase
added a commit
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove scaling from x-axis tick values like we did for y-axis tick values in ECharts charts
Before
No scaling ✔️
With scaling ❌
Static-viz with scaling ❌
After
With scaling ✔️
Static-viz with scaling ✔️
Note: This was meant to be handled by #43668 but the commit for the fix did not get pushed to the branch before it got merged.