Metabase channel

.clj-kondo/config.edn

@@ -162,6 +162,7 @@
     metabase.audit                 #{metabase.audit}
     metabase.bootstrap             #{metabase.bootstrap}
     metabase.cmd                   #{}                                                              ; there are no namespaces here since you shouldn't be using this in any other module.
+    metabase.channel               #{metabase.channel.core}
     metabase.config                #{metabase.config}
     metabase.core                  #{metabase.core.initialization-status}                           ; TODO -- only namespace used outside of EE, this probably belongs in `metabase.server` anyway since that's the only place it's used.
     metabase.db                    #{metabase.db
@@ -265,6 +266,7 @@
     metabase.bootstrap             #{}
     metabase.cmd                   :any
     metabase.compatibility         :any
+    metabase.channel               :any
     metabase.config                #{metabase.plugins}
     metabase.core                  :any
     metabase.db                    :any
@@ -412,6 +414,7 @@
     metabase.api.user                                             api.user
     metabase.api.util                                             api.util
     metabase.async.streaming-response.thread-pool                 thread-pool
+    metabase.channel.core                                         channel
     metabase.cmd.copy.h2                                          copy.h2
     metabase.config                                               config
     metabase.config.file                                          config.file

dev/src/dev.clj

@@ -69,7 +69,9 @@
    [metabase.driver :as driver]
    [metabase.driver.sql-jdbc.connection :as sql-jdbc.conn]
    [metabase.driver.sql-jdbc.execute :as sql-jdbc.execute]
+   [metabase.email :as email]
    [metabase.models.database :refer [Database]]
+   [metabase.models.setting :as setting]
    [metabase.query-processor.compile :as qp.compile]
    [metabase.query-processor.timezone :as qp.timezone]
    [metabase.server :as server]
@@ -386,3 +388,25 @@
         (when (failed?)
           (throw (ex-info (format "Test failed after running: `%s`" test)
                           {:test test})))))))
+
+
+(defn setup-email!
+  "Set up email settings for sending emails from Metabase. This is useful for testing email sending in the REPL."
+  [& settings]
+  (let [settings (merge {:host     "localhost"
+                         :port     1025
+                         :user     "metabase"
+                         :pass     "metabase@secret"
+                         :security :none}
+                        settings)]
+    (when (::email/error (email/test-smtp-connection settings))
+      (throw (ex-info "Failed to connect to SMTP server" {:settings settings})))
+    (setting/set-many! (update-keys settings
+                                    {:host        :email-smtp-host,
+                                     :user        :email-smtp-username,
+                                     :pass        :email-smtp-password,
+                                     :port        :email-smtp-port,
+                                     :security    :email-smtp-security,
+                                     :sender-name :email-from-name,
+                                     :sender      :email-from-address,
+                                     :reply-to    :email-reply-to}))))

dev/src/dev/render_png.clj

@@ -9,7 +9,6 @@
     [metabase.email.messages :as messages]
     [metabase.models :refer [Card]]
     [metabase.models.card :as card]
-    [metabase.models.user :as user]
     [metabase.pulse :as pulse]
     [metabase.pulse.markdown :as markdown]
     [metabase.pulse.render :as render]
@@ -30,11 +29,11 @@
   (condp
    #(<= 0 (.indexOf ^String %2 ^String %1))
    (.toLowerCase (System/getProperty "os.name"))
-    "win" :win
-    "mac" :mac
-    "nix" :unix
-    "nux" :unix
-    nil))
+   "win" :win
+   "mac" :mac
+   "nix" :unix
+   "nux" :unix
+   nil))
 
 ;; taken from https://github.com/aysylu/loom/blob/master/src/loom/io.clj
 (defn- open
@@ -81,16 +80,20 @@
      nil
      query-results)))
 
-(defn open-hiccup-as-html
-  "Take a hiccup data structure, render it as html, then open it in the browser."
-  [hiccup]
-  (let [html-str (hiccup/html hiccup)
-        tmp-file (File/createTempFile "card-html" ".html")]
+(defn open-html
+  "Take a html string, then open it in the browser."
+  [html-str]
+  (let [tmp-file (File/createTempFile "card-html" ".html")]
     (with-open [w (io/writer tmp-file)]
       (.write w ^String html-str))
     (.deleteOnExit tmp-file)
     (open tmp-file)))
 
+(defn open-hiccup-as-html
+  "Take a hiccup data structure, render it as html, then open it in the browser."
+  [hiccup]
+  (open-html (hiccup/html hiccup)))
+
 (def ^:private execute-dashboard #'pulse/execute-dashboard)
 
 (defn render-dashboard-to-pngs

enterprise/backend/test/metabase_enterprise/advanced_config/api/pulse_test.clj

@@ -8,31 +8,32 @@
 
 (deftest test-pulse-endpoint-should-respect-email-domain-allow-list-test
   (testing "POST /api/pulse/test"
-    (t2.with-temp/with-temp [Card card {:dataset_query (mt/mbql-query venues)}]
+    (t2.with-temp/with-temp [Card card {:name          "Test card"
+                                        :dataset_query (mt/mbql-query venues)}]
       ;; make sure we validate raw emails whether they're part of `:details` or part of `:recipients` -- we
       ;; technically allow either right now
       (doseq [channel [{:details {:emails ["test@metabase.com"]}}
                        {:recipients [{:email "test@metabase.com"}]
                         :details    {}}]]
         (testing (format "\nChannel = %s\n" (u/pprint-to-str channel))
           (letfn [(send! [expected-status-code]
-                    (let [pulse-name (mt/random-name)]
-                      (mt/with-fake-inbox
-                        {:response   (mt/user-http-request
-                                      :rasta :post expected-status-code "pulse/test"
-                                      {:name          pulse-name
-                                       :cards         [{:id                (u/the-id card)
-                                                        :include_csv       false
-                                                        :include_xls       false
-                                                        :dashboard_card_id nil}]
-                                       :channels      [(merge {:enabled       true
-                                                               :channel_type  "email"
-                                                               :schedule_type "daily"
-                                                               :schedule_hour 12
-                                                               :schedule_day  nil}
-                                                              channel)]
-                                       :skip_if_empty false})
-                         :recipients (set (keys (mt/regex-email-bodies (re-pattern pulse-name))))})))]
+                    (mt/with-fake-inbox
+                      {:response   (mt/user-http-request
+                                    :rasta :post expected-status-code "pulse/test"
+                                    {:name          (mt/random-name)
+                                     :cards         [{:id                (u/the-id card)
+                                                      :include_csv       false
+                                                      :include_xls       false
+                                                      :dashboard_card_id nil}]
+                                     :channels      [(merge {:enabled       true
+                                                             :channel_type  "email"
+                                                             :schedule_type "daily"
+                                                             :schedule_hour 12
+                                                             :schedule_day  nil}
+                                                            channel)]
+                                     :alert_condition "rows"
+                                     :skip_if_empty false})
+                       :recipients (set (keys (mt/regex-email-bodies (re-pattern "Test card"))))}))]
             (testing "allowed email -- should pass"
               (mt/with-premium-features #{:email-allow-list}
                 (mt/with-temporary-setting-values [subscription-allowed-domains "metabase.com"]