Fix field values remapping with models & custom dropdown source in public dashboards #44099
+186
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
changed the title
|
ranquild
commented
Jun 12, 2024
| return dimension?.field(); | ||
| } | ||
|
|
||
| if (isConcreteFieldReference(fieldRef)) { |
There was a problem hiding this comment.
This is taken from master and adopted for MLv1
ranquild
changed the title
ranquild
commented
Jun 13, 2024
| @@ -99,6 +99,7 @@ class FieldInner extends Base { | |||
|
|
|||
| // added when creating "virtual fields" that are associated with a given query | |||
| query?: StructuredQuery | NativeQuery; | |||
| _comesFromEndpoint?: boolean; | |||
There was a problem hiding this comment.
This is an existing field which was previously untyped
ranquild
commented
Jun 13, 2024
| return { ...parameter, hasVariableTemplateTagTarget: true }; | ||
| return { | ||
| ...parameter, | ||
| hasVariableTemplateTagTarget: !isDimensionTarget(target), |
There was a problem hiding this comment.
Fix from master. In case we fail to find the field, do not assume it's a native query variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44047
Repro https://www.loom.com/share/bd15abd6412f46d0aa778f3388169e34
I didn't manage to repro the same issue in E2E no matter what I tried. So I made API calls with data for what I reproduced locally - see the video above. The repro is not 100% correct as the model query doesn't execute. But without the fix the repro fails, which is good.
In the issue we're hitting this
metabase/frontend/src/metabase-lib/Dimension.ts
Line 843 in ddf5b10
How to verify: