Track metabase.nqa module dependencies #44464
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
added
.Team/BackendComponents
crisptrutski
commented
Jun 20, 2024
| [metabase.driver.util :as driver.u] | ||
| [metabase.lib.native :as lib.native] |
There was a problem hiding this comment.
We still depend on both these modules, but metabase.lib is the higher-level one.
|
This reverts commit 445230b.
crisptrutski
commented
Jun 20, 2024
| (let [driver (driver.u/database->driver (:database query))] | ||
| (let [driver (lib.native/engine query)] |
There was a problem hiding this comment.
It turns out we can't actually make this change (yet?) as our test queries don't have the required :lib/type and :stages values used by the validation for this helper.
qnkhuat
approved these changes
Jun 21, 2024
github-automation-metabase
pushed a commit
that referenced
this pull request
Jun 21, 2024
github-automation-metabase
added a commit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first stage of recovery is acceptance.
Here we declare all the module dependencies of
metabase.native-query-analyzer.