Fix unable to sync json column with value is an array #44465
Merged
+86
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnkhuat
commented
Jun 20, 2024
| (recur path key (assoc! res next-path clojure.lang.PersistentVector))) | ||
| JsonToken/END_ARRAY (recur path key res))))))) | ||
| ;; only parse if the value is an object, ignore arrays, strings, numbers, etc. | ||
| (and (zero? token-cnt) |
There was a problem hiding this comment.
jackson doesn't have a peek method :(
There was a problem hiding this comment.
Why don't we check (seq res) here, seems like it should give the same result? Nothing collected and not a start of the object -> goodbye.
qnkhuat
commented
Jun 20, 2024
| res (transient {})] | ||
| (let [token (.nextToken p) | ||
| next-path (cond-> path key (conj key))] | ||
| (loop [path (or path []) |
There was a problem hiding this comment.
The fix here is reverese https://github.com/metabase/metabase/pull/43812/files, then add a check to make sure we return nil if the value is not an object.
|
Thread for context |
qnkhuat
added
the
backport
piranha
reviewed
Jun 20, 2024
|
|
need to backport to 49 too |
piranha
approved these changes
Jun 20, 2024
github-automation-metabase
pushed a commit
that referenced
this pull request
Jun 20, 2024
github-automation-metabase
added a commit
that referenced
this pull request
Jun 20, 2024
|
@metabase-bot backport release-x.49.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a json column with values is an array or an atom should not have nested fields
Closes #44459