Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - Missing schema name in data picker #44468

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Fix - Missing schema name in data picker #44468

merged 3 commits into from
Jun 21, 2024
+54 −3

Conversation

kamilmielnik
Copy link
Contributor

@kamilmielnik kamilmielnik commented Jun 20, 2024 •
edited
Loading

Closes #44460

How to verify

  1. Start a new question
  2. Search for any table in the Data Picker (e.g. Orders)

Name of the schema the table belongs to should be displayed next to database name.

note: some databases don't have schemas (e.g. Maria, Mongo)

Demo

Before

image

After

image

@kamilmielnik kamilmielnik changed the title Show table's schema name when available Fix - Missing schema name in data picker Jun 20, 2024
@kamilmielnik kamilmielnik self-assigned this Jun 20, 2024
@kamilmielnik kamilmielnik requested review from a team and removed request for a team June 20, 2024 11:05
@kamilmielnik kamilmielnik added the backport Automatically create PR on current release branch on merge label Jun 20, 2024
@kamilmielnik kamilmielnik marked this pull request as ready for review June 20, 2024 11:10
@kamilmielnik kamilmielnik requested review from a team and AlessioLaiso June 20, 2024 11:11
@replay-io replay.io
Copy link

replay-io bot commented Jun 20, 2024 •
edited
Loading

Status Complete ↗︎
Commit 52b6379
Results
⚠️ 1 Flaky
✅ 2687 Passed

@kamilmielnik kamilmielnik merged commit fa192d9 into master Jun 21, 2024
111 checks passed
@kamilmielnik kamilmielnik deleted the 44460-data-picker-schema-name branch June 21, 2024 13:19
github-automation-metabase pushed a commit that referenced this pull request Jun 21, 2024
@kamilmielnik
Fix - Missing schema name in data picker (#44468)
06ba383 
* Show table's schema name when available

* Add a test

* Add a test for empty table schema
@github-automation-metabase github-automation-metabase mentioned this pull request Jun 21, 2024
Merged
github-automation-metabase added a commit that referenced this pull request Jun 21, 2024
@github-automation-metabase @kamilmielnik
Fix - Missing schema name in data picker (#44468) (#44541)
97dd5f9 
* Show table's schema name when available

* Add a test

* Add a test for empty table schema

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
@attaxia
Copy link

attaxia commented Jun 28, 2024 •
edited
Loading

This should be reopened. Although it was solved in the specific instance shown in the screenshot above (search results), it is not solved on the recents tab of the same screen, nor the Search modal next to the "New" button in the top right corner.
@kamilmielnik

@kamilmielnik kamilmielnik mentioned this pull request Jun 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romeovs romeovs romeovs approved these changes

@ranquild ranquild ranquild approved these changes

@AlessioLaiso AlessioLaiso Awaiting requested review from AlessioLaiso

Assignees

@kamilmielnik kamilmielnik

Labels
backport Automatically create PR on current release branch on merge .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing schema name in data picker
4 participants
@kamilmielnik @attaxia @romeovs @ranquild