-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dashboard description max length limit to 1.5K #44470
Conversation
72af7df
to
e1a67ea
Compare
|
e1a67ea
to
0bff792
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have at least like a single test for each of these components?
edited: I came to think about it, this is already a schema, maybe there's no need to test that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original thread mentions questions as well and even though we don't have validation for creating questions, there is 255 limit on cloning questions in frontend/src/metabase/questions/components/CopyQuestionForm.tsx
let's keep questions in a separate scope and do it as a part of a larger design effort |
0bff792
to
b0f86a0
Compare
b0f86a0
to
a0d4674
Compare
I meant there is a bug that can be fixed right here by changing 1 constant. We already allow adding >255 chars to a question description when creating a question but the duplication form has wrong validation: Screen.Recording.2024-06-25.at.10.54.46.AM.mov |
* Bump dashboard description max len limit to 1.5K * Extract `DASHBOARD_DESCRIPTION_MAX_LENGTH` const * Handle description max length in dashboard sidebar * Add red border to dashboard description box * Add test
…#44470) (#44751) * Bump dashboard description max length limit to 1.5K (#44470) * Bump dashboard description max len limit to 1.5K * Extract `DASHBOARD_DESCRIPTION_MAX_LENGTH` const * Handle description max length in dashboard sidebar * Add red border to dashboard description box * Add test * Use `color` fn instead of CSS variables
Part of #43983, internal discussion here
Bumps dashboard description max length to 1500, it's validated when a dashboard is created, copied, or whenever it's changed via the dashboard sidebar
Demo
CleanShot.2024-06-25.at.15.39.09.mp4