Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dashboard description max length limit to 1.5K #44470

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

kulyk
Copy link
Member

@kulyk kulyk commented Jun 20, 2024

Part of #43983, internal discussion here

Bumps dashboard description max length to 1500, it's validated when a dashboard is created, copied, or whenever it's changed via the dashboard sidebar

Demo

CleanShot.2024-06-25.at.15.39.09.mp4

@kulyk kulyk added backport Automatically create PR on current release branch on merge .Team/DashViz Dashboard and Viz team labels Jun 20, 2024
@kulyk kulyk self-assigned this Jun 20, 2024
@kulyk kulyk force-pushed the 43983-description-max-len-limits branch from 72af7df to e1a67ea Compare June 20, 2024 12:06
Copy link

replay-io bot commented Jun 20, 2024

Status Complete ↗︎
Commit a0d4674
Results
⚠️ 2 Flaky
2694 Passed

@kulyk kulyk force-pushed the 43983-description-max-len-limits branch from e1a67ea to 0bff792 Compare June 21, 2024 11:39
@kulyk kulyk requested review from kdoh, vbenedetti and a team June 21, 2024 11:39
@kulyk kulyk changed the title Remove dashboard and question description max length limit on the FE Bump dashboard description max length limit to 1.5K Jun 21, 2024
Copy link
Member

@WiNloSt WiNloSt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have at least like a single test for each of these components?

edited: I came to think about it, this is already a schema, maybe there's no need to test that.

Copy link
Member

@alxnddr alxnddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original thread mentions questions as well and even though we don't have validation for creating questions, there is 255 limit on cloning questions in frontend/src/metabase/questions/components/CopyQuestionForm.tsx

@perivamsi
Copy link
Contributor

The original thread mentions questions as well and even though we don't have validation for creating questions, there is 255 limit on cloning questions in frontend/src/metabase/questions/components/CopyQuestionForm.tsx

let's keep questions in a separate scope and do it as a part of a larger design effort

@kulyk kulyk force-pushed the 43983-description-max-len-limits branch from 0bff792 to b0f86a0 Compare June 25, 2024 13:11
@kulyk kulyk force-pushed the 43983-description-max-len-limits branch from b0f86a0 to a0d4674 Compare June 25, 2024 14:37
@kulyk kulyk requested review from alxnddr and a team June 25, 2024 14:41
@alxnddr
Copy link
Member

alxnddr commented Jun 25, 2024

let's keep questions in a separate scope and do it as a part of a larger design effort

I meant there is a bug that can be fixed right here by changing 1 constant. We already allow adding >255 chars to a question description when creating a question but the duplication form has wrong validation:

Screen.Recording.2024-06-25.at.10.54.46.AM.mov

@kulyk kulyk merged commit 9ce72a4 into master Jun 26, 2024
113 checks passed
@kulyk kulyk deleted the 43983-description-max-len-limits branch June 26, 2024 10:31
kulyk added a commit that referenced this pull request Jun 26, 2024
* Bump dashboard description max len limit to 1.5K

* Extract `DASHBOARD_DESCRIPTION_MAX_LENGTH` const

* Handle description max length in dashboard sidebar

* Add red border to dashboard description box

* Add test
kulyk added a commit that referenced this pull request Jun 26, 2024
…#44470) (#44751)

* Bump dashboard description max length limit to 1.5K (#44470)

* Bump dashboard description max len limit to 1.5K

* Extract `DASHBOARD_DESCRIPTION_MAX_LENGTH` const

* Handle description max length in dashboard sidebar

* Add red border to dashboard description box

* Add test

* Use `color` fn instead of CSS variables
@github-actions github-actions bot added this to the 0.50.8 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/DashViz Dashboard and Viz team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants