Fix field visibility in the model editor #45816
Draft
+123
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
added
the
backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff bcd5a00...ef62859.
|
|
| @@ -837,6 +841,47 @@ describe("issue 39993", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe("issue 33844", () => { | |||
There was a problem hiding this comment.
This symptom is also present in master.
LMK if you think we should fix this separately.
- New -> Model -> Orders
- Metadata -> Select ID -> Detail views only -> Save
- Make sure the ID column is hidden in Simple mode now
- Open Metadata Editor again. ID column should be visible and the value should "Detail views only".
- Cancel editing, discard changes
ID column is visible in simple mode
- Open Metadata Editor again.
ID column has "Table and details views" setting.
2024-07-19.15-08-04.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33844
Previously, if you set "Detail views only" setting on a field in Model metadata, the editor would somewhat break. There are many symptoms of this problem. Now the setting is only saved but has no effect on data displayed in the table itself - the fields would be always visible.
How to verify: