Dashboard list filters & favouriting & archival [WIP]

[attekei]

TODO

• Add filter widget
• Add "Saved by me" filter
• Add "Favorites" filter
• Add favouriting button to each list item
• Add archival button to each list item
• Add archive list
• Add unarchive button
• Separate URL for the archive page
• Use real API endpoints instead of mocks
• Empty states for filters & archive list

• for the dropdown filters (favorites, saved by me), let’s use the same empty state that we use for the text-based filters (the empty dashboard illustration plus text)
• for the archive empty state, let’s repurpose the Collection empty state: icon should change to the archive box icon, and the text should read “No dashboards have been archived yet”
• if the dashboard archive is non-empty, the icon for it should appear in the top-right of the dashboard list empty state

• Change "Delete" button in dashboard editing state to "Archive"
• Check why there is some tiny flickering when you change active filter
• Dashboard list item UI changes, specifically:

• move the dashboard icon to the right (i’ve depicted how to handle the hover states, which remain essentially unchanged)
• change the box’s hover state (it adds a box-shadow now instead of making the bg blue, and it makes the title text blue)
• change the font style of dashboard titles to match the style used for question titles in the list of questions (dark gray/black, 18pt)

• Add E2E tests (and sync again w/ Tom about how to make them stable)

Maybe skipped for now because of implementation complexity:

• Add "Recently viewed" filter (check if the backend has everything set)
• Add "Most popular" filter (also might require something from the backend)

[salsakran]

@attekei for things like most popular where we don't have a sort method on the endpoint, let's just skip that option for now

[attekei]

roger

[attekei]

updated this 9:15pm

Ready for first UI review cycle, please note that:

• empty states are missing for "Favorites" + "Saved by me" filters and "Archive". I could recycle the same empty states that are in Questions list with slightly modified texts. Questions archive doesn't currently have an empty state but imho both question and dashboard archives should have one.
• dashboard deletion in the single dashboard editing view has to still be changed to dashboard archival

[mazameli]

Looking good. Here are some things I noticed:

• We never explicitly talked about this, but I didn't necessarily expect dashboards to have their own archive page as opposed to questions — though I think it makes sense now that I see it. Only reason it gave me pause was because archived collections and archived questions go in the same archive bucket.
• I think that the list of dashboards in the archive should look visually like the question archive page. We intentionally made that archive page a bit more stripped down to make it feel more like a recycling bin type view.
• When the archive button appears on hover with a dashboard with a long name, the ellipsified state of the title is still too close to the archive icon. I'd like it to have padding-right == to the space between the archive icon and the star. Ellipsified titles are actually also too close to the star icon even when not in the hover state.
• In the filter dropdown, I think the all dashboards icon should be our dashboard icon instead of the stack/collections icon.

[salsakran]

thanks for putting up with my OCD tendencies and moving the icon.
👍 on this once we get a few tests wired up

[kdoh]

Just a couple small class usage things but after those are fixed this looks good.

[kdoh]

I think the Icon element should get these Icon classes automatically based on the name so no need to duplicate them here.

[attekei]

Icon class doesn't currently merge them to the provided className parameter but I will make it do that :-)

[kdoh]

Same deal here r.e. Icon classes.

[kdoh]

Don't actually need to use cx here since there aren't any conditional classes on this element.