Make Oracle SID connection param optional

[camsaul]

I don't know a lot about Oracle DBs but I have heard whispers in #4345 that specifying SID is not required, nor is it a BASIC NEED for all Oracle users. So let's make that param optional.

Includes tests

[alee792]

Just tested, but there seems to be some validation that's throwing an exception:

05-03 19:19:10 DEBUG metabase.middleware :: POST /api/database 400 (75 ms) (0 DB calls)
{:valid false,
:dbname "java.sql.SQLRecoverableException: IO Error: Invalid connection string format, a valid format is: "host:port:sid" ",
:message "java.sql.SQLRecoverableException: IO Error: Invalid connection string format, a valid format is: "host:port:sid" "}

Looks like it's still validating for an sid.

[camsaul]

That validation isn't coming from Metabase, that's coming from the Oracle JDBC driver itself. Are you sure you don't have an SID? I don't think the driver would require one if it wasn't something everyone had

[camsaul]

It sounds like maybe you can get your SID like this

SELECT sys_context('USERENV', 'SID') FROM DUAL;

[camsaul]

It sounds like ORCL and XE are common default SIDs

[alee792]

That's what our DBA is telling me. I've tried a few different methods of pulling the SID, including the one you have posted above, to no avail. He did send over what he thinks the full JDBC string, so I'm going to test that independently right now to make sure he knows what he's talking about.

[camsaul]

ok. Is the format like jdbc:oracle:thin:@//ipadress:portnumber/service_name? If so I can try tweaking a couple of things to construct the string like that (right now we're trying jdbc:oracle:thin:@//ipadress:portnumber?serviceName=service_name which sounds like it doesn't work)

[alee792]

Yep, that first one is what should work. I'm going to check it out in python to see if I can successfully connect.

[camsaul]

Ok. Check out #4954. I pushed a branch that constructs the connection string that way instead of relying on params. Let me know if that works

[alee792]

Wooho, it's connected! Nothing's showing up in the data model right now, but the logs show it working through the schema. Thanks @camsaul!

[camsaul]

@alee792 awesome!