-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 16 upgrade [WIP] #6130
React 16 upgrade [WIP] #6130
Conversation
If anyone wants to pick this up I'm not going to be able to work on it for a couple weeks. |
Ok I've upgraded to React 16, but it still needs a ton of testing due to how React 16 error handling works. Basically React 16 gives you a chance to handle errors thrown in So we need to find and fix some bugs that weren't previously a big deal. We can also add Read more here https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html |
20fc720
to
09a1c55
Compare
FYI I've moved the relevant parts of the previous branch to a new branch from |
Superseded by #6756 #6757 #6758
Upgrade some dependencies to allow upgrading to React 16. Haven't tracked down all dependencies causing warnings, yet.
createClass
react-sortable
React.PropTypes
react-sortable
redux-auth-wrapper
redux-form
replacereact-sortable
fix element disappearing while draggingApp
as a fallbackVisualization
UserAvatar
incorrect merging ofstyles
constrainToScreen
shouldn't crash if null element is passedTableInteractive
cell measuring code usesReactDOM.unstable_renderSubtreeIntoContainer
ReactDOM.unstable_renderSubtreeIntoContainer
withReactDOM.createPortal
where possibleBodyComponent
Modal
WindowModal
FullPageModal
Popover
Issues I've found migrating tests to Enzyme v1 and React v16:
app.update()
in some places, in particular afterstore.waitForActions()
in integration testselement.find()
doesn't include the element itselfelement.hasClass("...")
etcselect.find(Popover)
(or children of Popover) no longer works, butapp.find(Popover)
may