Stream all JSON responses [ci drivers] #6623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches from `ring.middleware.json/wrap-json-response` to a new function that will stream JSON responses. Before this change the full JSON response was serialized to a String first, then written to the response stream. This change will skip that step and write the response to a PipedOutputStream directly. This is the same approach that was used in the response for the `/database/:id/fields` route, just generalized and applied to all routes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches from
ring.middleware.json/wrap-json-responsetoa new function that will stream JSON responses. Before this change the
full JSON response was serialized to a String first, then written to
the response stream. This change will skip that step and write the
response to a PipedOutputStream directly.
This is the same approach that was used in the response for the
/database/:id/fieldsroute, just generalized and applied to allroutes.