Fix excessive DB calls on reference guide #6638
Conversation
src/metabase/models/field.clj
Outdated
| (filter i/can-read? (db/select Field :id [:in target-field-ids]))))] | ||
| (filter i/can-read? (-> Field | ||
| (db/select :id [:in target-field-ids]) | ||
| (hydrate :table)))))] |
There was a problem hiding this comment.
extra whitespace? Also personal preference but
(-> (db/select Field :id [:in target-field-ids])
(hydrate :table))is the way we do it everywhere else and personally I think that would be a little more readable here :)
There was a problem hiding this comment.
one other thought: we should probably go ahead and remove the :table after we use it for can-read? purposes. Otherwise it will get returned as part of the API response for every Field, which could potentially dramatically increase the size of the response
There was a problem hiding this comment.
😆 I added that space because I figured that's what you'd do. I'll remove it.
👍 on removing table after as well
There was a problem hiding this comment.
I’ve never seen the two spaces like that before. Is that a convention for threading macros? I see how it could make sense
|
probably not a bad idea to do a quick audit of places where we call |
|
@camsaul I briefly looked through the code for more instances of that and didn't see any. I'll double check a little more carefully though to be sure. |
Before this commit, via the `/database/:id/metadata`, we make a DB call for each field's target table. On databases with a larger number of these values, it can cause many database calls. This will fetch them via batch hydration first, which will significantly reduce the number of calls.
senior
force-pushed
the
fix-ref-guide-db-call-explosion
branch
from
c5d0c14
to
d86e7d9
Compare
Before this commit, via the
/database/:id/metadata, we make a DBcall for each field's target table. On databases with a larger number
of these values, it can cause many database calls. This will fetch
them via batch hydration first, which will significantly reduce the
number of calls.