Don't log info messages or async load Liquibase during compilation #9043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsaul
force-pushed
the
extra-logging-for-DynamicClassLoadHelper-errors
branch
from
ed4e934
to
c0dd52e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things that are only need to happen during runtime like loading Liquibase (done asychronously to speed up launch) or logging the "Starting Metabase" message. Check if we're compiling the uberjar and skip these if logging messages if we are.
Also: don't try to run sync tasks for Databases that no longer exist (previously caused a warning but didn't affect anything)