-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pie dsl string generation + tests #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
field 'v' is no longer available, use getter method instead
…of supplier.get(context)
Now gets package from module
This makes it more in line with the rest of the syntax fixup! Remove semicolons after module and import statements
To remove ambiguity between ImportCall and QCall
…om-upstream # Conflicts: # lang.test/build.gradle.kts
# Conflicts: # lang.test/src/test/java/mb/pie/lang/test/util/SimpleChecker.java # lang/trans/gen/java-ast/func_body.str
# Conflicts: # lang.test/src/test/java/mb/pie/lang/test/binary/add/addIntIntTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addPathPathAbsoluteRelativeTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addPathPathRelativeRelativeTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addPathStrTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrBoolTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrDataTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrIntTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrListTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrNullableIntNullTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrNullableIntValueTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrPathTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrStrTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrTupleTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/add/addStrUnitTestGenTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/land/landFalseFalseTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/land/landFalseTrueTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/land/landTrueFalseTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/land/landTrueTrueTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/lor/lorFalseFalseTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/lor/lorFalseTrueTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/lor/lorTrueFalseTest.java # lang.test/src/test/java/mb/pie/lang/test/binary/lor/lorTrueTrueTest.java # lang.test/src/test/java/mb/pie/lang/test/template.java.ignored # lang/lang.test/src/test/java/mb/pie/lang/test/binary/add/addListElem/AddListElemTest.java # lang/lang.test/src/test/java/mb/pie/lang/test/binary/add/addListList/AddListListTest.java # lang/lang.test/src/test/java/mb/pie/lang/test/binary/add/addPathPathAbsoluteAbsolute/AddPathPathAbsoluteAbsoluteTest.java # lang/lang.test/src/test/java/mb/pie/lang/test/binary/add/addPathPathRelativeAbsolute/AddPathPathRelativeAbsoluteTest.java
Does not pass due to negative number/id ambiguity
This was referenced Sep 3, 2020
Gohla
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like better string interpolation, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues with String grammar (
\
can now be followed by any character except newlines and carriage returns)Fix issues with string generation (
"$foo bar"
would incorrectly generatefoo + " bar"
, which is a type error iffoo
is not a string)Add SPT tests for strings (should these go in
lang.test/spt/
instead?)