Support separate CAA and EAA access keys #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CAA and EAA actually use different IA credentials to manage their collections. This splits the current configuration options into per-project ones.
mwiencek
force-pushed
the
project-access-keys
branch
from
7f40b56
to
e8f21dd
Compare
mwiencek
added a commit
to mwiencek/musicbrainz-server
that referenced
this pull request
May 23, 2024
This follows metabrainz/artwork-indexer#2 which is a prerequisite of IMG-84. The CAA and EAA actually use different IA credentials to manage their collections. This splits the current configuration options into per-project ones.
mwiencek
added a commit
to mwiencek/musicbrainz-server
that referenced
this pull request
May 23, 2024
This follows metabrainz/artwork-indexer#2 which is a prerequisite of IMG-84. The CAA and EAA actually use different IA credentials to manage their collections. This splits the current configuration options into per-project ones.
mwiencek
added a commit
to mwiencek/musicbrainz-server
that referenced
this pull request
May 23, 2024
This follows metabrainz/artwork-indexer#2 which is a prerequisite of IMG-84. The CAA and EAA actually use different IA credentials to manage their collections. This splits the current configuration options into per-project ones.
|
Tests are passing here, as well are the integration tests in metabrainz/musicbrainz-server#3275, so I think this is safe to merge. |
mwiencek
added a commit
to mwiencek/musicbrainz-server
that referenced
this pull request
May 24, 2024
This follows metabrainz/artwork-indexer#2 which is a prerequisite of IMG-84. The CAA and EAA actually use different IA credentials to manage their collections. This splits the current configuration options into per-project ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CAA and EAA actually use different IA credentials to manage their collections.
This splits the current configuration options into per-project ones.