-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(docs): Debugging with VSCode in Docker #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great @Shelly011s thanks a lot for opening this PR ! (and perfect timing too as the whole MetaBrainz team is having a documentation sprint :p )
Your additions look great, nothing to add for the content.
I would however suggest that we rearrange the existing text and your new text to make it clearer that there are two use cases: running the code directly in VSCode and running the code in Docker.
I'm thinking that distinction won't be clear to someone who is new to all this…
We can have two sub-sub-sections, one for each use case: "Running the code with Docker" first, as this what we usually recommended, and "Running the code with VSCode" after that.
As you mentioned, in that second sub-section we would want to mention manual installation of the dependencies. But rather than point to the bookbrainz-site repo, could I ask for another favor?
Could you please (in another PR) move any of the documentation files that you find in the root of the bookbrainz-site repo to this documentation repo? That's really where they should live !
Thanks a lot in advance for your help !
Oh, and I forgot to say, yes please do open a PR in bookbrainz-site to add your improvements to the vscode launch.json file ! |
There are 3 files that needs to be moved in this repo namely DEPENDENCIES_MANUAL_INSTALL.md, INSTALLATION_TROUBLESHOOTING.md, NODEJS_SETUP.md. |
Yes, that sounds exactly right. One of the files does already exist in the docs: INSTALLATION_TROUBLESHOOTING.md is more or less here: https://bookbrainz-dev-docs.readthedocs.io/en/latest/docs/troubleshooting.html |
I have made the desired changes. Once this PR is approved, I will remove the said duplicates from bookbrainz-site repo to prevent redundancy. Let me know if something needs to be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ! 🚀
I was thinking of mentioning "NODEJS_SETUP.md" file since there are no instructions for running the server manually in docs.
Also, can I create a PR for committing changes in launch.son file required for this setup.