Follow Up of PR#11 in bookbrainz-dev-docs #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelly011s
changed the title
MonkeyDo
requested changes
Apr 24, 2023
There was a problem hiding this comment.
Thanks for opening a PR @Shelly011s !
I can't seem to find the content of CONTRIBUTING.md in the developer docs, and I think generally it is probably one file we do want to keep on the repo side (it's a special sort of file, see here for some details )
So I'll ask to put that file back in. The other ones are fine on the developer docs, and now we won't have possible duplication :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is a follow up of PR in bookbrainz-dev-docs.
Solution
I have already copied the content of the deleted files in the PR.
Areas of Impact
I have deleted DEPENDENCIES_MANUAL_INSTALL.md, INSTALLATION_TROUBLESHOOTING.md, NODEJS_SETUP.md to prevent redundancy and moved/copied documents in the bookbrainz-dev-docs.