Lint pull requests

Fix(AC): users should be able to make Author Credits optional #793

Sign in to view logs

Triggered via pull request June 7, 2023 18:33

MonkeyDo

synchronize #871

Status Success

Total duration 2m 7s

Artifacts –

lint-pull-requests.yml

on: pull_request_target

Run linters for pull requests

Annotations

5 errors and 8 warnings

test/src/server/routes/unifiedform.js ► Unified form routes ► should not throw error when linking existing works to edition: test/src/server/routes/unifiedform.js#L216

Failed test found in: test-results.json Error: expected undefined to equal 1

test/src/server/routes/unifiedform.js ► Unified form routes ► should not throw error while creating multiple entities: test/src/server/routes/unifiedform.js#L177

Failed test found in: test-results.json Error: expected undefined to equal 2

test/src/server/routes/unifiedform.js ► Unified form routes ► should not throw error while creating single entity: test/src/server/routes/unifiedform.js#L78

Failed test found in: test-results.json Error: expected undefined to equal 1

test/src/server/routes/unifiedform.js ► Unified form routes ► should not throw error while linking existing edition-group to edition: test/src/server/routes/unifiedform.js#L266

Failed test found in: test-results.json Error: expected undefined to equal 1

test/src/server/routes/unifiedform.js ► Unified form routes ► should not throw error while linking existing publisher to edition: test/src/server/routes/unifiedform.js#L242

Failed test found in: test-results.json Error: expected undefined to equal 1

src/client/components/pages/revision.js#L108

This line has a length of 166. Maximum allowed is 150 (max-len)

src/client/components/pages/revision.js#L112

This line has a length of 163. Maximum allowed is 150 (max-len)

src/client/components/pages/revision.js#L119

This line has a length of 154. Maximum allowed is 150 (max-len)

src/client/components/pages/revision.js#L164

Unexpected 'todo' comment: 'TODO: Add proper error handling.' (no-warning-comments)

src/server/routes/editor.js#L561

Unexpected 'todo' comment: 'TODO: this can throw, so missing error...' (no-warning-comments)

src/server/routes/search.js#L59

'total' is assigned a value but never used (@typescript-eslint/no-unused-vars)

src/server/routes/search.js#L148

Unexpected 'todo' comment: 'TODO: This is hacky, and we should...' (no-warning-comments)

Run linters for pull requests

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, wearerequired/lint-action@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.