BB-373 React fontawesome — entity image #350
Conversation
There was a problem hiding this comment.
This one's going to be slightly trickier.
You'll have to dig into layered icons: if an entity is deleted, it should show the entity icon and overlapped by a big red slash icon.
Docs are here: https://github.com/FortAwesome/react-fontawesome#advanced
Here's what I'm currently seeing:
(You can compare it with https://test.bookbrainz.org/work/0527de58-7da4-4afd-8ba5-ba351aee1e28 for example)
|
If you're getting a 500 error when trying to visit an entity, that's because of a mismatch of bookbrainz-data package with the ORM update. Easy fix: merge or rebase master and it should work. |
MonkeyDo
changed the title
|
@prabalsingh24 I know you're already well busy writing tests and new PRs, but I'd love it if we could focus on closing up the FontAwesome job (finishing replacing the library, cleanup, and figuring out vertical alignment of the icons). |
|
I will finish this asap. :) Sorry for the delay |
No problem, I just wanted to make sure they're not forgotten, and to tie our loose ends :) |
|
I'd love to close up the FontAwesome update chapter before publishing a new version of the website. |
in entity image component
Auto-import the FA css, and some tweaks to make the layers work and prevent FOUC
MonkeyDo
force-pushed
the
react-fontawesome-BB373
branch
from
38ef249
to
f8c7d4e
Compare
This should conclude moving to the official FontAwesome package
|
Problem
https://tickets.metabrainz.org/browse/BB-373
https://tickets.metabrainz.org/browse/BB-386
Migrating React-FontAwesome : entities/image.js
Note from MonkeyDo: I also hijacked the PR to finish cleaning up the unused FontAwesome files made obsolete by the package change (BB-386)
Areas of Impact
src/client/components/pages/entities/image.js