BB-481: Fix merged entities path redirect #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove special case for '/create' routes (see previous commit), and added types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Links to merged bbids subpaths (for example
/$BBID/revisions) would redirect to the merged entity without the subpath (i.e:/$newBBID).Solution
Replace the bbid in the full path and redirect to that.
This PR also puts entity routes without BBIDs (/create, /create/handler) before the route parameters are defined for routes with bbids.
This allows us to remove an ugly solution to detect routes without bbid introduced in this commit:
0e1a834#diff-04b1046083d3d54b6df49ebe87477558
Also adds a bit of flow types
Areas of Impact
Entity router files and middleware helpers.