User collections create/edit route #425

prabalsingh24 · 2020-05-12T10:09:02Z

Problem

Added Collection-Create/Edit Route

coveralls · 2020-05-12T10:12:57Z

Coverage decreased (-0.9%) to 59.501% when pulling 21159eb on prabalsingh24:user-collections-createRoute into 5e8f534 on bookbrainz:UserCollection.

prabalsingh24 · 2020-05-12T13:33:57Z

This won't work rn. I made some changes in the bookshelf data and forgot to update it my project.
Edit : fixed it

src/client/components/forms/userCollection.js

src/server/helpers/collectionRouteUtils.js

src/server/helpers/middleware.js

prabalsingh24 · 2020-05-12T19:30:08Z

Thanks for a super quick review @MonkeyDo (I know you were busy w LB stuff :P )

prabalsingh24 · 2020-05-27T15:12:10Z

MonkeyDo

Preliminary review, before trying to run the code.
Looking good so far !

src/client/components/forms/userCollection.js

src/server/helpers/collectionRouteUtils.js

src/server/helpers/middleware.js

src/server/routes/collection.js

src/server/routes/search.js

MonkeyDo

Here's a review of the user interface, with a few improvements.

src/client/components/forms/userCollection.js

prabalsingh24 · 2020-06-03T15:36:17Z

Here's a review of the user interface, with a few improvements.

@MonkeyDo Thank you for the review. I will make these changes :)

MonkeyDo

A couple more comments after running into an issue locally :)

src/server/helpers/collectionRouteUtils.js

src/client/components/forms/userCollection.js

src/server/helpers/collectionRouteUtils.js

src/client/components/forms/userCollection.js

add fontawesome icons; remove duplicate collaborators in cleanedCollaborator function

src/client/components/forms/userCollection.js

MonkeyDo

There's still a couple of unresolved items from previous reviews, but after that I think it'll be ready to merge 👍

src/client/components/forms/userCollection.js

src/server/routes/search.js

src/server/helpers/collectionRouteUtils.js

src/client/components/forms/userCollection.js

prabalsingh24 · 2020-06-09T12:26:27Z

I didn't add <hr/>. Is this alright?

prabalsingh24 · 2020-06-09T12:33:28Z

I didn't add console.error(, Had to suppress eslint for that.

MonkeyDo

Great, ready to merge :)

prabalsingh24 self-assigned this May 12, 2020

prabalsingh24 changed the title ~~User collections create route~~ [WIP] User collections create route May 12, 2020

MonkeyDo reviewed May 12, 2020

View reviewed changes

prabalsingh24 force-pushed the user-collections-createRoute branch from d04b6a5 to 59f1632 Compare May 28, 2020 15:38

prabalsingh24 requested a review from MonkeyDo May 28, 2020 15:40

prabalsingh24 changed the title ~~[WIP] User collections create route~~ User collections create/edit route May 31, 2020

MonkeyDo reviewed Jun 1, 2020

View reviewed changes

MonkeyDo requested changes Jun 3, 2020

View reviewed changes

MonkeyDo reviewed Jun 4, 2020

View reviewed changes

src/client/components/forms/userCollection.js Outdated Show resolved Hide resolved

prabalsingh24 added 11 commits June 4, 2020 17:48

chore(user-collection): add userCollection Create Form

33d6879

chore(user-collection): add middleware and auth for user collection

577200f

chore(user-collection): add colletion-create and collection-edit route

e64060b

chore(user-collection): add userCollections in the elasticsearch index

60a15b1

refactor: use createOrEditHandler to remove duplicate code

bc88933

search: add userCollections in search.reindex

048921a

fix: fix typos

41ee0e0

refactor: valid -->isValid

c4bbe3c

refactor some names according to the change in schema

ed0f6b3

show error in the create form

e244b41

Don't let user edit entity_type if collection isn't empty

99a7fe7

prabalsingh24 force-pushed the user-collections-createRoute branch from 59f1632 to 85aebc4 Compare June 4, 2020 12:37

chore: no need to pass extra props in setState

f7013e3

prabalsingh24 force-pushed the user-collections-createRoute branch from 85aebc4 to f7013e3 Compare June 4, 2020 12:40

chore: refactor routes ordering;

ef656f6

add fontawesome icons; remove duplicate collaborators in cleanedCollaborator function

prabalsingh24 commented Jun 4, 2020

View reviewed changes

src/client/components/forms/userCollection.js Show resolved Hide resolved

fix some eslint errors

3dbbd2e

prabalsingh24 requested a review from MonkeyDo June 6, 2020 13:23

MonkeyDo requested changes Jun 8, 2020

View reviewed changes

src/client/components/forms/userCollection.js Show resolved Hide resolved

src/server/routes/search.js Outdated Show resolved Hide resolved

src/server/helpers/collectionRouteUtils.js Show resolved Hide resolved

src/client/components/forms/userCollection.js Show resolved Hide resolved

prabalsingh24 added 2 commits June 9, 2020 17:49

update last modified and add collaborator heading

3341194

undo reindex removed code

21159eb

prabalsingh24 requested a review from MonkeyDo June 9, 2020 12:32

MonkeyDo approved these changes Jun 9, 2020

View reviewed changes

MonkeyDo merged commit f15898a into metabrainz:UserCollection Jun 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User collections create/edit route #425

User collections create/edit route #425

prabalsingh24 commented May 12, 2020

coveralls commented May 12, 2020 •

edited

Loading

prabalsingh24 commented May 12, 2020 •

edited

Loading

prabalsingh24 commented May 12, 2020 •

edited

Loading

prabalsingh24 commented May 27, 2020 •

edited

Loading

MonkeyDo left a comment

MonkeyDo left a comment

prabalsingh24 commented Jun 3, 2020

MonkeyDo left a comment

MonkeyDo left a comment

prabalsingh24 commented Jun 9, 2020 •

edited

Loading

prabalsingh24 commented Jun 9, 2020

MonkeyDo left a comment

User collections create/edit route #425

User collections create/edit route #425

Conversation

prabalsingh24 commented May 12, 2020

Problem

coveralls commented May 12, 2020 • edited Loading

prabalsingh24 commented May 12, 2020 • edited Loading

prabalsingh24 commented May 12, 2020 • edited Loading

prabalsingh24 commented May 27, 2020 • edited Loading

MonkeyDo left a comment

Choose a reason for hiding this comment

MonkeyDo left a comment

Choose a reason for hiding this comment

prabalsingh24 commented Jun 3, 2020

MonkeyDo left a comment

Choose a reason for hiding this comment

MonkeyDo left a comment

Choose a reason for hiding this comment

prabalsingh24 commented Jun 9, 2020 • edited Loading

prabalsingh24 commented Jun 9, 2020

MonkeyDo left a comment

Choose a reason for hiding this comment

coveralls commented May 12, 2020 •

edited

Loading

prabalsingh24 commented May 12, 2020 •

edited

Loading

prabalsingh24 commented May 12, 2020 •

edited

Loading

prabalsingh24 commented May 27, 2020 •

edited

Loading

prabalsingh24 commented Jun 9, 2020 •

edited

Loading