Fix BB-453: Prevent multiple form submissions #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable submit button once clicked
Introduced in PR#438 when replacing superagent-bluebird-promise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A user can mash the submit button and the form will be submitted as many times as they clicked it before being redirected.
That's obviously an issue and resulted in a bunch of duplicates in the database.
Solution
Disable the submit button once submitted.
re-enable it if there was an error with the submission.
While I was in there, I also fixed a small issue introduced in #438 where a submission error message was not extracted properly from the response body following the replacement of superagent-bluebird-promise library with superagent itself.