Fix audit #438
Merged
Fix audit #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftmostcat
commented
Jun 4, 2020
| @@ -41,10 +41,9 @@ | |||
| "@fortawesome/free-brands-svg-icons": "^5.11.2", | |||
| "@fortawesome/free-solid-svg-icons": "^5.11.2", | |||
| "@fortawesome/react-fontawesome": "^0.1.7", | |||
| "babel-plugin-transform-require-ignore": "^0.1.1", | |||
There was a problem hiding this comment.
Moved to dev dependencies.
leftmostcat
commented
Jun 4, 2020
| @@ -81,8 +80,7 @@ function postSubmission(url: string, data: Map<string, mixed>): Promise { | |||
| */ | |||
|
|
|||
| const [, submissionEntity] = url.split('/'); | |||
| return request.post(url).send(data) | |||
| .promise() | |||
| return request.post(url).send(Object.fromEntries(data)) | |||
There was a problem hiding this comment.
Either superagent or superagent-bluebird-promise seems to have coerced Maps to plain JS objects previously, but this isn't the case with the update, so we do it ourselves.
leftmostcat
commented
Jun 4, 2020
| @@ -247,7 +247,7 @@ export function makeEntityCreateOrEditHandler( | |||
| entityType: string, | |||
| transformNewForm: Function, | |||
| propertiesToPick: string | string[], | |||
| isMergeHandler?: boolean = false | |||
| isMergeHandler: boolean = false | |||
There was a problem hiding this comment.
Gives off an error in the linter when both ? and a default value are provided.
MonkeyDo
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
npm lists numerous audit issues.
Solution
Address audit issues. Additionally, update dependencies and remove unneeded.
Areas of Impact
General.