-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adding Entity from Collection Page #487
Feat: Adding Entity from Collection Page #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice !
This is going to be a very useful feature!
src/client/components/pages/parts/add-entity-to-collection-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/add-entity-to-collection-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/add-entity-to-collection-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/add-entity-to-collection-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/add-entity-to-collection-modal.js
Outdated
Show resolved
Hide resolved
src/client/components/pages/parts/add-entity-to-collection-modal.js
Outdated
Show resolved
Hide resolved
What do you think of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like the last changes; having the success message show on the main page and autorefreshing the results will look really nice and smooth for the user.
I hadn't thought about the complication of having the pager component trigger the search, but I think with the suggestion below of using a reference it should be pretty seamless.
I think your solution definitely had merit, so well done for finding that :)
I forgot about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm super happy with how this is turning out! Really smooth!
One final tiny details before merging:
Great stuff! |
Problem
Adding Entity from Collection Page