Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add 500ms timeout after deleting a collection #509

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

prabalsingh24
Copy link
Contributor

Problem

One test was inconsistent and showing false negative. Adding timeout after deleting a collection will make sure that ES index is updated

Solution

wait 500ms after deleting a collection to make sure ES index is updated

Areas of Impact

test/src/server/routes/collection.js

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Thank you !

@MonkeyDo MonkeyDo merged commit a4439a6 into metabrainz:master Sep 8, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 60.976% when pulling 39434bb on prabalsingh24:add-timeout-in-test into a450600 on bookbrainz:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants