fix: convert collectionType to appropiate format before param-validation #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prabalsingh24
force-pushed
the
fix-edition-group-bug
branch
from
5d9f94a
to
6c3aff8
Compare
prabalsingh24
force-pushed
the
fix-edition-group-bug
branch
from
6c3aff8
to
4303792
Compare
MonkeyDo
reviewed
Sep 9, 2020
test/src/server/routes/collection.js
Outdated
| expect(collection.get('id')).to.equal(res.body.id); | ||
| expect(collection.get('ownerId')).to.equal(collectionOwner.get('id')); | ||
| expect(collection.get('name')).to.equal(data.name); | ||
| expect(collection.get('entityType')).to.equal(_.upperFirst(_.camelCase(data.entityType))); |
There was a problem hiding this comment.
Let's change the expectation specifically to what we expect it to be, 'EditionGroup'.
That way if anything changes and we don't receive 'EditionGroup' we'll know something is wrong.
test/src/server/routes/collection.js
Outdated
|
|
||
| expect(res.status).to.equal(200); | ||
| expect(updatedCollectionJSON.name).to.equal(newData.name); | ||
| expect(updatedCollectionJSON.entityType).to.equal(_.upperFirst(_.camelCase(newData.entityType))); |
prabalsingh24
force-pushed
the
fix-edition-group-bug
branch
from
693fc2a
to
8f22779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An error was occurring while creating Edition-Group collection.
Solution
In the
paramValidationmiddleware, I forgot to take convert entityType tocamel-casebefore validating it.Areas of Impact
src/server/helpers/middleware.js
test/src/server/routes/collection.js