Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(BB-615): Copy/Paste annotation text in FireFox <= 60 #601

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented Apr 15, 2021

Signed-off-by: Akash Gupta akashgp9@gmail.com

Problem

This PR Fixes: BB-615

Solution

Replaced the current <p class="annotation-content"> with a <pre class="annotation-content"> and overridden the existing <pre> css styles when className annotation-content is present.

Also Tested in some older version of Firefox browsers using BrowserStack.

Areas of Impact

annotation.js
style.less

Signed-off-by: Akash Gupta <akashgp9@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.9% when pulling 6a21d89 on akashgp09:browser-compatibility into 8a3c5d8 on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, that's a great solution !

@MonkeyDo MonkeyDo merged commit 1c810bd into metabrainz:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants