Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elasticSearch): search entities by identifiers #620

Merged

Conversation

akashgp09
Copy link
Contributor

@akashgp09 akashgp09 commented May 5, 2021

Signed-off-by: Akash Gupta akashgp9@gmail.com

Problem

Allow searching by enitity identifiers
This PR Fixes: BB-616

Solution

Added identifiers to elasticSearch index and match query.

Searching H. P. Lovecraft using it's VIAF identifier ID 66470391

Before

Screenshot from 2021-05-05 12-58-11

After

Screenshot from 2021-05-05 12-57-43

Areas of Impact

Signed-off-by: Akash Gupta <akashgp9@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.91% when pulling 34476d0 on akashgp09:search-entity-with-identifiers into 124ef7b on bookbrainz:master.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Simple to implement in the end, and works for all identifiers!
Searching by ISBN for example is common when searching for an edition.

Thanks!

@MonkeyDo MonkeyDo merged commit ef9316c into metabrainz:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants