-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix[BB-513] : added missing entity option for every search and prefilled the name #722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far.
I have some suggestions to improve a few things but generally you're going in the right direction, nicely done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last issue I found while testing, other than that it looks great, thanks !
Re-applying modification after merging commit 9e7fc2e (the code in question has moved from search-results.js to search.tsx page)
I took the liberty to fix a merge conflict, since it was not super trivial (nothing complicated but required knowing what moved where). |
Problem
BB-513 : Improve "Are we missing an entry?" section.
Solution
Added missing entity option in every search result and prefilled the new entity with searched name using query parameters.
Areas of Impact