Fix[BB-513] : added missing entity option for every search and prefilled the name #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonkeyDo
requested changes
Dec 2, 2021
MonkeyDo
requested changes
Dec 21, 2021
Re-applying modification after merging commit 9e7fc2e (the code in question has moved from search-results.js to search.tsx page)
|
I took the liberty to fix a merge conflict, since it was not super trivial (nothing complicated but required knowing what moved where). |
MonkeyDo
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BB-513 : Improve "Are we missing an entry?" section.
Solution
Added missing entity option in every search result and prefilled the new entity with searched name using query parameters.
Areas of Impact