Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-528: Index author in ElasticSearch #740

Merged
merged 8 commits into from
Sep 22, 2023

Conversation

tr1ten
Copy link
Collaborator

@tr1ten tr1ten commented Dec 10, 2021

Problem

BB-528 ticket for adding author name for work

Solution

index the author in ES and replace author with disambiguation for work having author

Before
before

After
after

Areas of Impact

  1. generateIndex to index author property.
  2. dropdown related component for relationship.

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on that!
I'm looking forward to this feature, i think it's very helpful.

I was entering a book just yesterday and wanted that exact feature !

src/common/helpers/search.js Outdated Show resolved Hide resolved
src/common/helpers/search.js Outdated Show resolved Hide resolved
src/client/entity-editor/common/entity.tsx Outdated Show resolved Hide resolved
src/client/entity-editor/common/linked-entity.tsx Outdated Show resolved Hide resolved
Use the Collection of Author models that we already fetched instead of fetching the Author entities again from the DB
Also support multiple authors
@MonkeyDo MonkeyDo changed the title Feat[BB-528]: Index author in ES BB-528 Index author in ElasticSearch Feb 27, 2023
@MonkeyDo MonkeyDo changed the title BB-528 Index author in ElasticSearch BB-528: Index author in ElasticSearch Feb 27, 2023
@MonkeyDo
Copy link
Contributor

I took the liberty to finish things up, better late than never !
Here's where I got to for showing the author in the autocomplete search results, keeping the disambiguation as it was before and styling the author names:
image

And as for the search page, authors are now used as search terms for work entities, which is super useful. For example I searched for "lovecraft" and I get both results with lovecraft in the name, but also work entities with the "written by" relationship toH. P. Lovecraft.
We display the authors in the same way as above:
image

@MonkeyDo MonkeyDo merged commit fd9d3ee into metabrainz:master Sep 22, 2023
4 checks passed
@MonkeyDo MonkeyDo mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants