Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out transitional CustomInput component #783

Merged
merged 19 commits into from
Feb 24, 2022

Conversation

LordSputnik
Copy link
Member

Problem

The CustomInput component was added as part of commit a965f46 during the transition from react-bootstrap 0.29.0 to 0.31.3. It was only ever intended to bridge the gap from the old Input API to the new Form* API, and is an unnecessary level of abstraction acting as a black box in many of our components.

Solution

This PR replaces each use of CustomInput with the equivalent react-bootstrap components (Form.Control, Form.Group, Form.Label, OverlayTrigger and Tooltip).

Areas of Impact

Inputs on the following pages:

/author/:bbid (add to collection modal)
/author/:bbid/delete
/author/:bbid/edit
/author/create
/collection/create
/edition-group/:bbid (add to collection modal)
/edition-group/:bbid/delete
/edition-group/:bbid/edit
/edition-group/create
/edition/:bbid (add to collection modal)
/edition/:bbid/delete
/edition/:bbid/edit
/edition/create
/editor/:id/achievements (drag and drop)
/editor/edit
/merge/submit/:bbid (works and editions)
/publisher/:bbid (add to collection modal)
/publisher/:bbid/delete
/publisher/:bbid/edit
/publisher/create
/register/details
/revision/:id (edit node form)
/search (search field)
/series/:bbid (add to collection modal)
/series/:bbid/delete
/series/:bbid/edit
/series/create
/work/:bbid (add to collection modal)
/work/:bbid/delete
/work/:bbid/edit
/work/create

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, everything looks great !

@MonkeyDo MonkeyDo merged commit e401e86 into metabrainz:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants