Join relationships using attributes, not strings #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amCap1712
commented
Sep 22, 2022
|
|
||
|
|
||
| class HelpersTestCase(TestCase): | ||
| @pytest.mark.database | ||
| class TestHelpers: |
There was a problem hiding this comment.
These tests were using mocks earlier and began to fail after I updated _relationship_link_helper. These mocks look fragile anyway so I updated these to use real data.
amCap1712
force-pushed
the
sqlalchemy-warnings
branch
from
11a1fc0
to
2c999c3
Compare
amCap1712
force-pushed
the
sqlalchemy-warnings
branch
from
2c999c3
to
7598a5b
Compare
This commit fixes the warning: RemovedIn20Warning: Using strings to indicate column or relationship paths in loader options is deprecated and will be removed in SQLAlchemy 2.0. Please use the class-bound attribute directly. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9) For rationale, see section: https://docs.sqlalchemy.org/en/14/changelog/migration_20.html#orm-query-joining-loading-on-relationships-uses-attributes-not-strings
To avoid introducing more warnings between now and a future PR that will switch the future flag to turn these warnings into errors in prod, turn these warning into errors in tests.
amCap1712
force-pushed
the
sqlalchemy-warnings
branch
from
7598a5b
to
8436303
Compare
This comment has been minimized.
This comment has been minimized.
amCap1712
added a commit
that referenced
this pull request
Oct 7, 2022
I introduced this bug in #96. Fix by using the correct entity in joinedload.
amCap1712
added a commit
that referenced
this pull request
Oct 8, 2022
I introduced this bug in #96. Fix by using the correct entity in joinedload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the warning:
RemovedIn20Warning: Using strings to indicate column or relationship paths in loader options is deprecated and will be removed in SQLAlchemy 2.0. Please use the class-bound attribute directly. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)
For rationale, see section: https://docs.sqlalchemy.org/en/14/changelog/migration_20.html#orm-query-joining-loading-on-relationships-uses-attributes-not-strings