New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for building Postgres 10 images. #5

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@paramsingh
Member

paramsingh commented Jul 24, 2018

I'm not sure if we need to merge this, but opening a PR would make reviews easier.

@mayhem

mayhem approved these changes Jul 24, 2018

Without having run any of this, it looks sane.

@mwiencek

LGTM. Let's not merge this and keep it in the 10 branch for now.

rsync"
add-apt-repository 'deb http://apt.postgresql.org/pub/repos/apt/ xenial-pgdg main'
wget --quiet -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add -

This comment has been minimized.

@mwiencek

mwiencek Jul 24, 2018

Member

I usually copy pubkeys into the repo for security reasons.

# In Dockerfile
COPY ACCC4CF8.asc /tmp/

# In postgres-base/install_postgres.sh
apt-key add /tmp/ACCC4CF8.asc
rm /tmp/ACCC4CF8.asc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment