LIB-28: allow using numbers as devices on Mac OS X #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for allowing drive numbers.
We explicitely call it in the platform files as mb_disc_unix_read(). This removes some "black magic" since all other unportable functions are also implemented in the platform files. This is also a prerequisite to accept numbers as drive names for Mac OS X, since we need to intercept the device name before opening it.
ghost
assigned 
Since Mac doesn't have stable disc drive device names, one can now additionally use drive numbers. The default is "1" which stands for the first optical disc drive. This should be the same numbering `drutil list` uses.
JonnyJD
added a commit
that referenced
this pull request
Sep 27, 2013
see pull request #37 and LIB-28 Conflicts: src/unix.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally accepts numbers as disc devices on Mac OS X. This number is taken to be the index (starting with 1) in the list of optical disc drives as given by
drutil list.The default for Mac is now
"1", with or without a disc inserted.Direct device names are still accepted, of course.
Tracked in http://tickets.musicbrainz.org/browse/LIB-28