Small fix in Favouritescreen UI (Song Title and Artist name are not displaying in light theme) #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akshaaatt Please review it. |
akshaaatt
requested changes
Mar 25, 2023
| @@ -365,11 +366,13 @@ fun OnPlaylistClickScreen(playlistID: Long) { | |||
| Column(Modifier.padding(start = 10.dp)) { | |||
| Text( | |||
| text = it.title, | |||
| color = androidx.compose.material3.MaterialTheme.colorScheme.onSurface | |||
| // color = androidx.compose.material3.MaterialTheme.colorScheme.onSurface | |||
| color= Color.White | |||
There was a problem hiding this comment.
This fix is incorrect. We should never hardcode color values for an app which supports both light mode and dark mode.
Rather, we should look to make the black colored card as white or the relevant color to adapt automatically for light mode.
There was a problem hiding this comment.
Okay, get it. Thank You 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the FavouriteSong screen, The song name and artist name are not displaying.
Solution:
Light Theme:
Dark Theme: