Make stats time code consistent #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some stats used to be for "last" period whereas other stats considered the "ongoing" period till the current date i.e. last week vs 7 days ago to today. All entity stats now use the last week/month/year periods. Also refactored the code a bit for de-duplicating stuff.
mayhem
approved these changes
Sep 28, 2021
|
|
||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def get_time_range(stats_range: str) -> Tuple[datetime, datetime, relativedelta, str]: | ||
| latest_listen_ts = get_latest_listen_ts() |
There was a problem hiding this comment.
A shame that this function is close, but not really close to get_dates_for_stats_range....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify what periods stats are calcualted for and make them consistent across all type/range of stats. The stats are to be calculated for the "last" period as per discussion in IRC. Comments in code describe what this means. We should probably explain this on the website as well so that users know when to expect a stats update and why their current listens are no longer reflecting in the stats the next day.