Update listen additional_info metadata added to spotify listens #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional question - should we also add submission_client to the last.fm importer? I don't think we have data from this API to fill in any other fields. |
|
Adding the fields to Last.FM importer sounds good. |
alastair
force-pushed
the
spotify-read-metadata
branch
from
2c64790
to
14d263d
Compare
Following the new guidelines that we came up with about the submission client and music service.
alastair
force-pushed
the
spotify-read-metadata
branch
from
27fa5a7
to
218d513
Compare
to use - additional_info.music_service (should be "spotify.com") - additional_info.origin_url Also removes a duplicate isListenFromThisService method which looks like an error and should be unused.
instead of listening_from
as well as duration_ms
Since this is used for testing if the listen is from spotify, this utility should test (with a regexp) if it is a spotify URL
…/listenbrainz-server into spotify-read-metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the documentation for what metadata to put in a listen. This PR updates listens added by our spotify reader to follow this format.
We added the following new fields to the documentation, but I didn't add all of them:
Not added:
Deprecated fields:
'listening_from': 'spotify'because it's replaced by'music_service': 'spotify.com'