Final Refactoring of the Frontend Codebase #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
akshaaatt
commented
Feb 17, 2022
akshaaatt
commented
- Last few files moved
- Mock Data moved
- Snapshots Updated
MonkeyDo
reviewed
Feb 17, 2022
| @@ -28,7 +28,7 @@ import { getPageProps } from "../utils/utils"; | |||
| import { getEntityLink } from "../stats/utils"; | |||
| import ComponentToImage from "./ComponentToImage"; | |||
|
|
|||
| import fakeData from "./year-in-music-data.json"; | |||
| import fakeData from "../../tests/__mocks__/year-in-music-data.json"; | |||
There was a problem hiding this comment.
Oh, well this line should just be deleted…
Thanks for cleaning up after me 😅
…d `user` and remove fake data from YearInMusic.tsx
MonkeyDo
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.