LB-1088: Separate North Korea and South Korea in artist origins map #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusicBrainz has separate areas for North Korea and South Korea but the LB artist origins map does not distinguish between the two. Got the geoJSON entries from https://geojson-maps.ash.ms/ Also move the GeoJSON file to stats folder, it was incorrectly moved to the tests folder during a repo structure refactor
Just moved it, forgot to update path
Maxr1998
added a commit
to Maxr1998/listenbrainz-server
that referenced
this pull request
Aug 28, 2022
The stats endpoint returns country codes as ISO 3166 alpha-3 code via pycountry. LB-1088 (metabrainz#1958) separated the two countries on the world map, but incorrectly used two letter codes, breaking the map matching in the frontend. This commit changes the country codes to the correct alpha-3 codes as defined by the ISO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, we're fixing Korea. No, we're not talking about international politics.
MusicBrainz has separate areas for North Korea and South Korea but the LB artist origins map does not distinguish between the two. We're fixing that.
I added the geoJSON entries for the separate countries, which I got from https://geojson-maps.ash.ms/
Also moved the GeoJSON (
world_countries.json) file to stats UI folder, it was incorrectly moved to the tests folder during a repo structure refactor (#1867)The result: