LB-567: Merge test scripts #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivam-kapila
force-pushed
the
merge-test-scripts
branch
from
ff2a866
to
fc1ae2f
Compare
paramsingh
reviewed
May 6, 2020
|
@brainzbot retest this please |
paramsingh
approved these changes
May 6, 2020
shivam-kapila
force-pushed
the
merge-test-scripts
branch
from
b4a2690
to
64898d0
Compare
vansika
suggested changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Listenbrainz currently has 4 test files
These all can be merged into one file.
Solution
All these can be merged into
test.shand appropriate options can be provided to run particular tests.test.sh(for all tests)test.sh fe(for frontend tests)test.sh spark(for spark tests)test.sh int(for integration tests)