-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB-619: Improve page navigation on History page #900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done on getting the navigation to work.
The component seems a bit cleaner too.
I can't test this locally (no stats), but I'm happy to do a round of testing on beta.
You can change the API URL in your config file to api.listenbrainz.org so that it would work without stats being present. |
We should document this somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployed on beta.
- The first load starts with
Top S of the Year 2020
right now, we'll probably fix it with the dual loading thing MrMonkey and alastair are working on. - The Graph transitions seem to have gotten weird, there's some invalid state between them. Maybe when we change state, we should set a
loading: true
and in the render function whenloading
is true show a Loading spinner.
@ishaanshah Can you please enable link sharing access for the loader demo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Just a few comments.
Problem
/user/u/history?page=4&range=all_time&entity=artist
, they see the page flash with the contents of page 1, before being replaced with the contents of page 4. Ideally the page should just show the data of page 4 immediately.Jira Ticket - LB-619
Solution
Using the
popstate
event to restore the data when back or forward button is pressed solves the issue.