LB-613: Show artist name on the release graph #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaanshah
changed the title
ishaanshah
force-pushed
the
ux_improv
branch
2 times, most recently
from
57f0a91
to
6963084
Compare
ishaanshah
changed the title
ishaanshah
changed the title
paramsingh
reviewed
Jun 10, 2020
|
paramsingh
approved these changes
Jun 10, 2020
| @@ -54,7 +54,7 @@ const searchForSpotifyTrack = async ( | |||
| return null; | |||
| }; | |||
|
|
|||
| const getArtistLink = (listen: any) => { | |||
| @@ -73,13 +73,12 @@ const getArtistLink = (listen: any) => { | |||
| return artistName; | |||
| }; | |||
|
|
|||
| // TODO: remove this "any" when a listen type has been defined. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We should show the artist name on the release graph. More than one artists can have releases with the same name and it can be hard to guess which artist the release belongs to.
Solution
This PR adds artist names to the release graphs. In addition to that links pointing to the particular entity on MusicBrainz are also added if the MBID is present.
Action
Should be merged after #900