Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logos #234

Merged
merged 2 commits into from
Aug 15, 2016
Merged

Update logos #234

merged 2 commits into from
Aug 15, 2016

Conversation

gentlecat
Copy link
Contributor

@mayhem
Copy link
Member

mayhem commented Aug 10, 2016

I don't even know how to review this.

@gentlecat
Copy link
Contributor Author

There's a Display the rich diff button next to each file at https://github.com/metabrainz/metabrainz.org/pull/234/files. I guess you could also switch to that branch and see how it looks on the website locally.

@mayhem
Copy link
Member

mayhem commented Aug 10, 2016

I really don't like the improved text. I think you should get others to review this, I'm not for merging this.

@gentlecat
Copy link
Contributor Author

Examples with large versions (old on the left, updated on the right):
screenshot 2016-08-15 20 33 27
screenshot 2016-08-15 20 32 08
screenshot 2016-08-15 20 32 14
screenshot 2016-08-15 20 34 14
screenshot 2016-08-15 20 30 22
screenshot 2016-08-15 20 30 27
screenshot 2016-08-15 20 32 45

@gentlecat
Copy link
Contributor Author

Updated version of small logos are already used on https://musicbrainz.org/ and https://critiquebrainz.org/ (see navbars).

@chirlu
Copy link
Contributor

chirlu commented Aug 15, 2016

As I’ve said repeatedly before, I’m all for fixing the haphazard letter heights (which are plain ugly), so +1.

The new texts are less condensed than the original ones. I’m on the fence about that.

Why the reversed colours for Picard?

@mwiencek
Copy link
Member

mwiencek commented Aug 15, 2016

The proportions in the new ones look better and are easier to read to me. Otherwise they aren't much different except for being slightly wider. +1

@gentlecat
Copy link
Contributor Author

The new texts are less condensed than the original ones.

Right, that's another thing that makes it looks slightly differently. But that's the same Roboto Black that was used originally.

Why the reversed colours for Picard?

That's a bug. I'll fix it.

@gentlecat
Copy link
Contributor Author

There was a discussion about this PR and associated ticket during the weekly meeting. See https://chatlogs.metabrainz.org/brainzbot/metabrainz/2016-08-15/?msg=3668733&page=5.

@ApeKattQuest-MonkeyPython

fwiw the reversed colours on picard look better to me.

@gentlecat gentlecat merged commit 0829430 into master Aug 15, 2016
@gentlecat gentlecat deleted the logos branch August 15, 2016 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants