-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logos #234
Update logos #234
Conversation
I don't even know how to review this. |
There's a |
I really don't like the improved text. I think you should get others to review this, I'm not for merging this. |
Updated version of small logos are already used on https://musicbrainz.org/ and https://critiquebrainz.org/ (see navbars). |
As I’ve said repeatedly before, I’m all for fixing the haphazard letter heights (which are plain ugly), so +1. The new texts are less condensed than the original ones. I’m on the fence about that. Why the reversed colours for Picard? |
The proportions in the new ones look better and are easier to read to me. Otherwise they aren't much different except for being slightly wider. +1 |
Right, that's another thing that makes it looks slightly differently. But that's the same Roboto Black that was used originally.
That's a bug. I'll fix it. |
There was a discussion about this PR and associated ticket during the weekly meeting. See https://chatlogs.metabrainz.org/brainzbot/metabrainz/2016-08-15/?msg=3668733&page=5. |
fwiw the reversed colours on picard look better to me. |
See http://tickets.musicbrainz.org/browse/MEB-38.