Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes #338

Closed
wants to merge 2 commits into from
Closed

Minor changes #338

wants to merge 2 commits into from

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Oct 24, 2019

No description provided.

@enjeck enjeck changed the title Minor changes (WIP) Minor changes Oct 24, 2019
@enjeck enjeck changed the title (WIP) Minor changes Minor changes Oct 24, 2019
mayhem
mayhem approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your commit, these do tighten up the language a bit. I'm curious, how did you come to submit this PR? Did you read our policies and felt that they needed improving or are you using some automated too?

Either way, thanks!

@enjeck
Copy link
Contributor Author

enjeck commented Oct 28, 2019

@mayhem It was a combination of reading through them and also using Grammarly :D

Freso
Freso reviewed Oct 28, 2019
View reviewed changes
Copy link
Member

@Freso Freso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I have a couple of questions which may need input from others. Thanks for poking this!

metabrainz/templates/index/code-of-conduct.html Show resolved Hide resolved
metabrainz/templates/index/code-of-conduct.html Show resolved Hide resolved
metabrainz/templates/index/gdpr.html Show resolved Hide resolved
metabrainz/templates/index/gdpr.html Show resolved Hide resolved
metabrainz/templates/index/gdpr.html Show resolved Hide resolved
metabrainz/templates/index/gdpr.html Show resolved Hide resolved
metabrainz/templates/index/gdpr.html Show resolved Hide resolved
@joker314 joker314 mentioned this pull request Dec 7, 2019
Merged
@mayhem
Copy link
Member

mayhem commented Jan 12, 2021

I forked this, fixed up minor issues and merged it. Thanks1

@mayhem mayhem closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freso Freso Freso left review comments

@mayhem mayhem mayhem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enjeck @mayhem @Freso