Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musicbrainz Docker issue fixes #94

Closed
wants to merge 2 commits into from

Conversation

pingupingu
Copy link
Contributor

  • Use the correct oracle jdk (failing to find the correct image)
  • Add the correct yarn key instead of using an old version that has expired

yvanzo pushed a commit that referenced this pull request Feb 13, 2019
The previous oracle-jdk image has vanished on Jan, 24.
@pingupingu
Copy link
Contributor Author

@yvanzo Should I create a separate request to update the yarn key?

@yvanzo
Copy link
Contributor

yvanzo commented Feb 15, 2019

Thank you @pingupingu for both reporting bugs and proposing changes. No need to create another request as both issues are now fixed (thus closing this pull request):

  • I merged your commit about to update oracle jdk image name (which changed on Jan, 24);
  • I fixed Yarn issue with commit 2906242 by refreshing the Yarn Packaging subkey instead.
    Note: Downloading the signing key from the same server as the signed packages bypasses the main purpose of signature check. The fact this method is given in Yarn install docs is yet another issue.
    Edit: Additionally opened Fix APT package installation failure by refreshing keys musicbrainz-server#912

@yvanzo yvanzo closed this Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants