Skip to content

Commit

Permalink
Fix innocuous warning about cover art presence
Browse files Browse the repository at this point in the history
`cover_art_presence` is legitimately not defined by default.
It used to be compared only when adding/reordering cover art.
Since commit 722f8f2, it is compared very often, flooding logs.
  • Loading branch information
yvanzo committed Jan 11, 2021
1 parent a561edd commit 9c937d4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/MusicBrainz/Server/Entity/Release.pm
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ has 'cover_art_presence' => (
);

sub may_have_cover_art {
return shift->cover_art_presence ne 'darkened';
my $cover_art_presence = shift->cover_art_presence;

return !defined $cover_art_presence || $cover_art_presence ne 'darkened';
}

sub may_have_discids {
Expand Down

0 comments on commit 9c937d4

Please sign in to comment.